gtktreeviewaccessible: Fix potential uses of uninitialised variables
authorPhilip Withnall <philip.withnall@collabora.co.uk>
Wed, 20 Nov 2013 17:25:25 +0000 (17:25 +0000)
committerPhilip Withnall <philip.withnall@collabora.co.uk>
Mon, 2 Dec 2013 10:36:26 +0000 (10:36 +0000)
Found with scan-build.

https://bugzilla.gnome.org/show_bug.cgi?id=712760

gtk/a11y/gtktreeviewaccessible.c

index 21e86b32e51463c6f4b9d3b4c0441f75ce83bb0c..a3a11201c5ab3f48a90f1f89495f3d347ee535aa 100644 (file)
@@ -762,7 +762,11 @@ gtk_tree_view_accessible_get_selected_rows (AtkTable  *table,
 
   widget = gtk_accessible_get_widget (GTK_ACCESSIBLE (table));
   if (widget == NULL)
-    return 0;
+    {
+      if (rows_selected != NULL)
+        *rows_selected = NULL;
+      return 0;
+    }
 
   data.treeview = GTK_TREE_VIEW (widget);
   data.array = g_array_new (FALSE, FALSE, sizeof (gint));
@@ -1016,6 +1020,12 @@ gtk_tree_view_accessible_get_cell_area (GtkCellAccessibleParent *parent,
   GtkTreeViewAccessibleCellInfo *cell_info;
   GtkCellAccessible *top_cell;
 
+  /* Default value. */
+  cell_rect->x = 0;
+  cell_rect->y = 0;
+  cell_rect->width = 0;
+  cell_rect->height = 0;
+
   widget = gtk_accessible_get_widget (GTK_ACCESSIBLE (parent));
   if (widget == NULL)
     return;
@@ -1256,7 +1266,7 @@ gtk_tree_view_accessible_get_renderer_state (GtkCellAccessibleParent *parent,
       GtkTreeViewColumn *column;
       GtkTreePath *path;
       GtkRBTree *tree;
-      GtkRBNode *node;
+      GtkRBNode *node = NULL;
       
       gtk_tree_view_get_cursor (treeview, &path, &column);
       if (path)